[cfg, megatron, doc] fix: drop unused actor.router_replay in favor of engine config - #7466
Open
YeonwooSung wants to merge 2 commits into
Open
[cfg, megatron, doc] fix: drop unused actor.router_replay in favor of engine config#7466YeonwooSung wants to merge 2 commits into
YeonwooSung wants to merge 2 commits into
Conversation
…agrees with engine Fixes verl-project#7463 Co-authored-by: Grok <grok@x.ai> Signed-off-by: YeonwooSung <neos960518@gmail.com>
YeonwooSung
requested review from
PeterSH6,
eric-haibin-lin,
tongyx361,
vermouth1992,
wucong25 and
wuxibin89
as code owners
August 19, 2026 02:04
wuxibin89
reviewed
Aug 20, 2026
Review: keep only actor.{megatron,veomni}.router_replay.
Fixes verl-project#7463
Co-authored-by: Grok <grok@x.ai>
Signed-off-by: YeonwooSung <neos960518@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7463.
actor.yamlexposedactor_rollout_ref.actor.router_replay, but Megatron/VeOmni workers only readactor.{megatron,veomni}.router_replay. The documented top-level key was a silent no-op.Per review, this PR drops the unused top-level key instead of aliasing it:
router_replayfromactor.yamland fromActorConfig.actor.megatron.router_replay/actor.veomni.router_replay.experimental/separationwhen deciding R2 vs R3.actor_rollout_ref.actor.router_replay.mode=...now fails in Hydra struct mode. The supported override isactor_rollout_ref.actor.megatron.router_replay.mode=R3(orveomni).Closed #3762 asked whether routing replay would be supported (it is). This issue is the leftover dead key.
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI)Test
Ruff passed on the touched Python files. Please run the CPU test in CI.
API and Usage Example
Design & Code Changes
The worker already selected
self.config.actor.megatron.router_replay/self.config.actor.veomni.router_replay. Removing the unused actor-level schema avoids a second source of truth.ref.router_replayinref.yamlis unchanged; this review only asked to drop the actor-level key.Checklist Before Submitting
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysActorConfigno longer has a top-levelrouter_replayfield and that the engine field still works.ci-requestchannel in theverlSlack workspace.recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.AI assistance was used to locate the bug and apply the review. A human author should review every changed line.